From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX Date: Thu, 04 Jun 2026 13:33:46 +1000 Message-ID: In-Reply-To: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add HDMI 2.0 support to DW HDMI QP TX Author: Cristian Ciocaltea Patches: 31 Reviewed: 2026-06-04T13:33:46.578470 --- This is a well-structured and thoroughly documented v7 series from Cristian Ciocaltea (Collabora) that adds HDMI 2.0 SCDC scrambling support to the DW HDMI QP TX controller, enabling 4K@60Hz on Rockchip RK3576/RK3588 SoCs. The decomposition is clean: generic DRM infrastructure first (patches 1-11), driver implementation (12-15), platform wiring (16-23), vc4 conversion as proof of reuse (24-25), and KUnit tests (26-30). The series has several Reviewed-by/Tested-by tags from prior rounds. The overall design is sound: scrambling state is managed by common helpers (`drm_scdc_start/stop_scrambling`) that coordinate source-side callbacks with sink-side SCDC programming and periodic status monitoring via a delayed work item. Hotplug reconnections trigger CRTC resets to restore lost SCDC state. I have a few substantive items worth addressing, detailed below. --- Generated by Claude Code Patch Reviewer