From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: sii9234: use extcon to detect cable attachment Date: Thu, 04 Jun 2026 12:19:46 +1000 Message-ID: In-Reply-To: <20260602-exynos4-sii9234-driver-v4-0-9b2fc38e104a@grimler.se> References: <20260602-exynos4-sii9234-driver-v4-0-9b2fc38e104a@grimler.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: sii9234: use extcon to detect cable attachment Author: Henrik Grimler Patches: 4 Reviewed: 2026-06-04T12:19:46.158919 --- This is a clean, well-structured 3-patch series that adds extcon-based MHL cable detection to the sii9234 bridge driver. The motivation is sound -- without extcon, the MHL chip must stay permanently on and HDMI hotplug doesn't work. The implementation closely mirrors the existing sii8620 driver (commit 688838442147), which is the right approach. Patches 1 and 2 are straightforward cleanups (typos and dev_err_probe conversion). Patch 3 is the functional change. The series has Reviewed-by from Dmitry Baryshkov and Tested-by from Marek Szyprowski. This is on its 4th revision and appears ready. One issue worth flagging in patch 3 (race window on remove), and a couple minor observations below. --- Generated by Claude Code Patch Reviewer