From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible Date: Thu, 04 Jun 2026 13:12:22 +1000 Message-ID: In-Reply-To: <20260602-fastrpc-v2-1-67a55e22427b@oss.qualcomm.com> References: <20260602-fastrpc-v2-1-67a55e22427b@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: dt-bindings: misc: qcom,fastrpc: Add Maili FastRPC compatible Author: Yijie Yang Patches: 1 Reviewed: 2026-06-04T13:12:22.346708 --- This is a single-patch series adding a new compatible string (`qcom,maili-f= astrpc`) to the Qualcomm FastRPC device tree binding. The patch is trivial = and straightforward =E2=80=94 it adds a new SoC-specific compatible that fa= lls back to the existing `qcom,kaanapali-fastrpc` compatible, following the= established pattern in the binding. The change is correct and properly placed in alphabetical order within the = enum list. No functional concerns. However, there is a discrepancy between the **patch base** and the **curren= t drm-next tree**: the binding on drm-next (shown above) only has `qcom,gly= mur-fastrpc` in the inner enum (lines 27-28), while the patch context shows= both `qcom,glymur-fastrpc` and `qcom,hawi-fastrpc`. This means the patch i= s based on a tree that already includes the `qcom,hawi-fastrpc` addition (l= ikely already queued elsewhere), which explains why it didn't apply cleanly= . This is not a problem with the patch itself =E2=80=94 it just needs to be= applied on top of the tree that includes the `hawi` entry. --- Generated by Claude Code Patch Reviewer