From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Fix indirect CSD jobs with zeroed workgroups Date: Thu, 04 Jun 2026 12:49:57 +1000 Message-ID: In-Reply-To: <20260602-v3d-fix-indirect-csd-v3-0-cc79e06e543c@igalia.com> References: <20260602-v3d-fix-indirect-csd-v3-0-cc79e06e543c@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Fix indirect CSD jobs with zeroed workgroups Author: =?utf-8?q?Ma=C3=ADra_Canal?= Patches: 3 Reviewed: 2026-06-04T12:49:57.798267 --- This is a clean, well-motivated two-patch bugfix series for the V3D DRM driver's indirect CSD (compute shader dispatch) path. When userspace defers workgroup counts to a GPU buffer and those counts turn out to be zero, two bugs are exposed: (1) a vaddr leak from an early return that skips cleanup, and (2) the hardware misinterpreting 0 as 65536, causing incorrect shader execution instead of a no-op. Both patches are small, focused, correctly ordered (fix the leak first so it doesn't mask the skip), carry proper Fixes/Cc-stable tags, and have been reviewed (Iago's R-b). The series is in good shape and ready to be applied. **Verdict: No issues found. The series looks good.** --- Generated by Claude Code Patch Reviewer