From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Date: Thu, 04 Jun 2026 13:25:57 +1000 Message-ID: In-Reply-To: <20260602004515.1907422-1-runyu.xiao@seu.edu.cn> References: <20260602004515.1907422-1-runyu.xiao@seu.edu.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Author: Runyu Xiao Patches: 4 Reviewed: 2026-06-04T13:25:57.081447 --- This is a single-patch fix (v3) that replaces `generic_handle_irq()` with `= generic_handle_irq_safe()` in the LPE audio IRQ forwarding path. The change= is correct and well-motivated: on PREEMPT_RT kernels, i915's IRQ handler r= uns in threaded context (not hard IRQ context), so `generic_handle_irq()` = =E2=80=94 which requires hard IRQ context =E2=80=94 is inappropriate. `gene= ric_handle_irq_safe()` wraps the call with `local_irq_save()`/`local_irq_re= store()`, making it safe from any context. The fix is minimal, one-line, and uses the correct upstream API. The commit= message accurately describes the problem and the solution. The current drm= -next tree still has `generic_handle_irq()` at line 265, confirming this fi= x is still needed. **One process concern:** The Signed-off-by chain has Maarten Lankhorst as F= rom/author with his own Signed-off-by, then Runyu Xiao's Signed-off-by as t= he submitter. The v3 changelog says this is a rebase of Maarten's original = fix. The Reviewed-by tags from Matthew Brost and Uma Shankar are carried fo= rward =E2=80=94 this is acceptable if the patch content hasn't materially c= hanged from what they reviewed, which appears to be the case (same one-line= change). **Verdict: Looks good.** This is a straightforward, correct RT fix. --- --- Generated by Claude Code Patch Reviewer