From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Preserve user address when PASID is disabled
Date: Thu, 04 Jun 2026 13:24:31 +1000 [thread overview]
Message-ID: <review-overall-20260602040624.2206774-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260602040624.2206774-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Preserve user address when PASID is disabled
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-06-04T13:24:31.255992
---
This is a single-patch fix for the `accel/amdxdna` driver. The bug is clear: when PASID is disabled, `amdxdna_hmm_register()` returns early without setting `abo->mem.uva`, so it stays at `AMDXDNA_INVALID_ADDR` (its initialization value from `amdxdna_gem_create_obj()` at line 178). Later, `amdxdna_init_dev_bo()` calls `amdxdna_gem_uva(heap)` on each heap BO and checks:
```c
heap_addr = amdxdna_gem_uva(heap);
if (heap_addr == AMDXDNA_INVALID_ADDR) {
XDNA_ERR(xdna, "Heap %d is not mapped", heap_id);
return -EAGAIN;
}
```
This validation always fails in the no-PASID path because `uva` was never populated, even though the BO was successfully mapped. The fix is correct and minimal.
One minor observation: there is a behavioral asymmetry between the PASID-on and PASID-off paths after this patch that is worth noting but not blocking.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 3:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 4:06 [PATCH V1] accel/amdxdna: Preserve user address when PASID is disabled Lizhi Hou
2026-06-02 14:15 ` Mario Limonciello
2026-06-02 15:40 ` Lizhi Hou
2026-06-04 3:24 ` Claude review: " Claude Code Review Bot
2026-06-04 3:24 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260602040624.2206774-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox