From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/dumb-buffers: Increase size limits to match current devices Date: Thu, 04 Jun 2026 13:08:23 +1000 Message-ID: In-Reply-To: <20260602073027.192758-1-tzimmermann@suse.de> References: <20260602073027.192758-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/dumb-buffers: Increase size limits to match current devices Author: Thomas Zimmermann Patches: 4 Reviewed: 2026-06-04T13:08:23.071360 --- This is a single patch from Thomas Zimmermann that increases the hardcoded = sanity limits for dumb buffer creation from 8192x8192 at 32bpp to 16384x163= 84 at 64bpp. It fixes commit `5ab62dd3687b` which introduced overly strict = limits that broke CI and high-end devices (e.g., 64bpp formats like XRGB161= 61616F, and resolutions beyond 8K). **The patch targets an older codebase.** On the current drm-next tree, the = file has been significantly refactored =E2=80=94 the hardcoded width/height= /bpp limits this patch modifies have been entirely removed and replaced wit= h proper overflow-safe arithmetic (`check_mul_overflow`, `DIV_ROUND_UP` wit= h explicit `U32_MAX` bounds, and format-aware pitch calculation via `drm_mo= de_size_dumb()`). This explains why the patch does not apply cleanly. This patch is likely intended for **stable backport** or an older branch wh= ere the refactoring hasn't landed yet. As a fix for the original limiting c= ommit, the approach is reasonable. --- Generated by Claude Code Patch Reviewer