From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dumb-buffer: Drop buffer-size limits for now
Date: Thu, 04 Jun 2026 12:51:35 +1000 [thread overview]
Message-ID: <review-overall-20260602112842.252279-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260602112842.252279-1-tzimmermann@suse.de>
Overall Series Review
Subject: drm/dumb-buffer: Drop buffer-size limits for now
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 3
Reviewed: 2026-06-04T12:51:35.907861
---
This is a single patch that removes overly restrictive hard-coded size limits (8192x8192 @ 32bpp) from `drm_mode_create_dumb()`, added by the recent commit 5ab62dd3687b. The limits broke CI tests and were too aggressive — they'd reject legitimate use cases like 8K displays (7680x4320) and 64bpp formats (`XRGB16161616F`) that are explicitly supported elsewhere in the same file (line 176 of the current tree). The removal is correct: the remaining arithmetic overflow checks in `drm_mode_create_dumb()` are mathematically sound and sufficient to prevent the integer overflows the original commit was targeting.
**Verdict: The patch is good and should be applied.** Minor nits on tag ordering below.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 11:24 [PATCH] drm/dumb-buffer: Drop buffer-size limits for now Thomas Zimmermann
2026-06-03 8:53 ` Saarinen, Jani
2026-06-03 10:30 ` Jani Nikula
2026-06-04 2:51 ` Claude Code Review Bot [this message]
2026-06-04 2:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260602112842.252279-1-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox