Claude review: drm/sched: Remove redundant entity->rq initialization and checks

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/sched: Remove redundant entity->rq initialization and checks
Author: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Patches: 3
Reviewed: 2026-06-04T12:41:19.912219

---

This is a single-patch cleanup that removes dead code from the DRM scheduler. The analysis is correct: after commit 28c5bf28763d ("drm/sched: Disallow initializing entities with no schedulers"), `drm_sched_entity_init()` validates that `sched_list` is non-empty and non-NULL, then unconditionally sets `entity->rq = &sched_list[0]->rq`. No code path in the scheduler ever sets `entity->rq` back to NULL after init. Therefore, the NULL checks in `kill`, `flush`, and `job_init` are dead code.

The patch also correctly identifies a latent bug in the removed dead code: the `dev_err(job->sched->dev, ...)` in `drm_sched_job_init()` would dereference `job->sched` before it has been initialized — `job->sched` is only assigned later in `drm_sched_job_arm()`, and the `memset(job, 0, ...)` hasn't even run yet at that point, so `job->sched` is whatever garbage was in the caller's allocation.

The patch is correct and safe to apply, with one minor issue noted below.

---
Generated by Claude Code Patch Reviewer