From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Export symbols for KUnit test modules Date: Thu, 04 Jun 2026 12:38:58 +1000 Message-ID: In-Reply-To: <20260602161536.3909009-1-alex.hung@amd.com> References: <20260602161536.3909009-1-alex.hung@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Export symbols for KUnit test modules Author: Alex Hung Patches: 2 Reviewed: 2026-06-04T12:38:58.621766 --- This is a single straightforward fix patch that adds missing `EXPORT_IF_KUN= IT()` calls for three functions: `amdgpu_dm_psr_set_event`, `amdgpu_dm_ism_= init`, and `amdgpu_dm_ism_fini`. These exports are needed so that KUnit tes= t modules can resolve the symbols when `CONFIG_DRM_AMD_DC_KUNIT_TEST=3Dm`. The patch follows the established pattern exactly =E2=80=94 every other exp= orted-for-KUnit function in this directory uses the same `EXPORT_IF_KUNIT()= ` macro from `amdgpu_dm_kunit_helpers.h`, placed immediately after the func= tion's closing brace. Both modified files already include that header. The = macro correctly expands to `EXPORT_SYMBOL()` when `CONFIG_DRM_AMD_DC_KUNIT_= TEST` is enabled and to nothing otherwise, so there is no impact on non-KUn= it builds. **One observation:** The Fixes tags reference commits `7c1bb28ce2f0` ("Add = KUnit tests for amdgpu_dm_psr_set_event") and `4db0dd9e5a63` ("Add more KUn= it tests for amdgpu_dm_ism") which are not present in the current drm-next = tree. The existing test files (`amdgpu_dm_psr_test.c` and `amdgpu_dm_ism_te= st.c`) on drm-next don't call any of these three functions =E2=80=94 they t= est `amdgpu_dm_psr_fill_caps`, `dm_ism_next_state`, `dm_ism_get_sso_delay`,= and `dm_ism_get_idle_allow_delay` instead. This patch presumably fixes tho= se commits in a topic branch where the new tests were already added. The ma= intainer should confirm proper ordering so this patch lands alongside or af= ter the commits it fixes. **Verdict: Patch looks correct.** No functional concerns. --- --- Generated by Claude Code Patch Reviewer