From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: move lifetime to `Bar0` Date: Thu, 04 Jun 2026 12:32:33 +1000 Message-ID: In-Reply-To: <20260602170416.2268531-1-gary@kernel.org> References: <20260602170416.2268531-1-gary@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: move lifetime to `Bar0` Author: Gary Guo Patches: 4 Reviewed: 2026-06-04T12:32:33.435558 --- This is a single patch (not a series) from Gary Guo that changes the `Bar0`= type alias in the nova-core GPU driver from an owned MMIO type to a refere= nce-wrapped `pci::Bar` type, effectively moving the reference lifetime into= the type alias itself. The motivation is well-explained: the `Mmio` deref = target type is slated for removal when the I/O projection series lands, and= embedding the reference in the type alias prepares nova-core for a smooth = transition to direct `Io` implementations. The transformation is almost entirely mechanical =E2=80=94 33 files are tou= ched, but the vast majority of changes are `&Bar0` =E2=86=92 `Bar0<'_>` and= `&'a Bar0` =E2=86=92 `Bar0<'a>`. Since the new `Bar0<'a>` is `&'a pci::Bar= <'a, BAR0_SIZE>` (a `Copy` type), all call sites preserve their semantics. = The patch compiles cleanly against whatever base it targets (base-commit `4= d789488d3bec`), and the approach is sound. **Minor issues:** a typo in the commit message, and one non-mechanical chan= ge in `gpu.rs` that deserves a brief explanation. --- Generated by Claude Code Patch Reviewer