From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: track individual colorop updates Date: Thu, 04 Jun 2026 12:16:43 +1000 Message-ID: In-Reply-To: <20260602215743.914265-1-mwen@igalia.com> References: <20260602215743.914265-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: track individual colorop updates Author: Melissa Wen Patches: 5 Reviewed: 2026-06-04T12:16:43.925332 --- This is a clean, well-structured 4-patch bug-fix series at v8. It addresses= two related issues in the DRM color pipeline (colorop) infrastructure: 1. **lut1d/lut3d interpolation properties were incorrectly treated as immut= able** =E2=80=94 stored on `drm_colorop` instead of `drm_colorop_state`, me= aning changes from userspace went to the wrong place and weren't tracked pe= r-atomic-state. 2. **Individual colorop property changes were not tracked** =E2=80=94 chang= ing a colorop property (bypass, curve type, LUT data, multiplier, interpola= tion) didn't set `plane_state->color_mgmt_changed`, so drivers had no way t= o know color blocks needed updating. This broke gamescope night-mode (shape= r/3D-LUT updates). The series is logically ordered: first fix docs (patch 1), then fix the dat= a model (patch 2), then add change tracking in the core (patch 3), then wir= e it up in AMD's driver (patch 4). Each patch is independently correct, has= appropriate Fixes tags, and carries reviewed-by tags from multiple reviewe= rs (Intel, AMD). The code is straightforward, follows existing patterns, an= d I found no correctness bugs. **Recommendation: This series looks ready to merge.** --- --- Generated by Claude Code Patch Reviewer