From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for the BOE BF068MWM-TD0 Date: Thu, 04 Jun 2026 11:48:25 +1000 Message-ID: In-Reply-To: <20260603-asteroids-panel-support-v1-0-109c6ac81c8f@pm.me> References: <20260603-asteroids-panel-support-v1-0-109c6ac81c8f@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add support for the BOE BF068MWM-TD0 Author: Alexander Koskovich Patches: 6 Reviewed: 2026-06-04T11:48:25.026307 --- This is a 2-patch series adding support for the BOE BF068MWM-TD0 6.77" 1080x2392 AMOLED panel used in the Nothing Phone (3a). The DT binding is clean and well-structured. The panel driver follows established patterns (generated via `linux-mdss-dsi-panel-driver-generator`) and uses the modern `devm_drm_panel_alloc` and `mipi_dsi_multi_context` APIs. There is one **bug** in the `prepare()` error paths: failures after `boe_bf068mwm_td0_on()` succeeds (PPS or compression_mode) return directly without cleaning up regulators/GPIO. The nearly identical `panel-novatek-nt37801.c` driver, which this appears modeled on, handles this correctly with `goto err`. There's also a build dependency on an out-of-tree flag (`MIPI_DSI_MODE_DSC_ALL_SLICES_IN_PKT`) that should be noted. --- --- Generated by Claude Code Patch Reviewer