From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915: Fix double cleanup in error paths Date: Thu, 04 Jun 2026 11:52:28 +1000 Message-ID: In-Reply-To: <20260603-fix_i915-v1-0-7479ff64e705@bootlin.com> References: <20260603-fix_i915-v1-0-7479ff64e705@bootlin.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915: Fix double cleanup in error paths Author: Kory Maincent Patches: 6 Reviewed: 2026-06-04T11:52:28.153352 --- This is a 3-patch series fixing double-cleanup issues in i915 display conne= ctor/encoder error paths. The core claim is correct for patches 1 and 3: on= ce `drm_connector_init_with_ddc()` succeeds, the DRM core owns the object a= nd will call `.destroy` during teardown, so manual cleanup in error paths c= auses double-free. However, **patch 2 has a significant problem** =E2=80=94= it introduces a resource leak by removing cleanup that is actually needed. The series is Cc: stable, which is appropriate for patches 1 and 3 but patc= h 2 needs rework. Overall the direction is right but the LVDS patch needs a= different approach. --- Generated by Claude Code Patch Reviewer