From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Date: Thu, 04 Jun 2026 11:45:49 +1000 Message-ID: In-Reply-To: <20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com> References: <20260603-shikra-display-v1-0-aeac1b94faa7@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Subject: [PATCH 0/5] Add Shikra (QCM2290) display support Author: Nabige Aala Patches: 11 Reviewed: 2026-06-04T11:45:49.945957 --- This is a 5-patch series adding display subsystem support for the Qualcomm = Shikra (QCM2290) SoC. The series is straightforward: Shikra reuses the same= MDSS/DPU 6.5 hardware as QCM2290, so the patches are mostly adding new com= patible strings pointing to existing driver data structures and catalog ent= ries. The series is generally correct and functional, but has two categories of i= ssues: 1. **Sorting violations**: Several of the `of_device_id` match table insert= ions break the established alphabetical ordering in the SMMU tables and per= petuate an existing sort anomaly in the DPU/MDSS tables. 2. **Design question on fallback compatibles**: Since Shikra uses identical= hardware to QCM2290, the standard DT convention would be to use fallback c= ompatibles in the device tree (e.g., `compatible =3D "qcom,shikra-dpu", "qc= om,qcm2290-dpu"`). This would avoid needing new match table entries in `dpu= _kms.c` and `msm_mdss.c` entirely =E2=80=94 the driver would match on the e= xisting `qcom,qcm2290-*` entries. The DSI controller already implicitly use= s this pattern via the `qcom,mdss-dsi-ctrl` fallback. The DT maintainers wi= ll likely raise this. The cover letter has a malformed Subject line with a duplicate prefix: `[PA= TCH 0/5] Subject: [PATCH 0/5] Add Shikra...` No DTS file is included =E2=80=94 presumably that will come in a separate s= eries. --- --- Generated by Claude Code Patch Reviewer