From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: move probe resources into registration data Date: Thu, 04 Jun 2026 11:21:43 +1000 Message-ID: In-Reply-To: <20260603-use_tyr_reg_data-v1-1-97f64e951cf6@collabora.com> References: <20260603-use_tyr_reg_data-v1-1-97f64e951cf6@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/tyr: move probe resources into registration data Author: Deborah Brouwer Patches: 1 Reviewed: 2026-06-04T11:21:43.367133 --- This is a single well-structured patch that moves probe-time resources (pla= tform device, clocks, regulators, MMIO mapping, firmware state, GPU info) o= ut of `TyrDrmDeviceData` and into a new `TyrDrmRegistrationData<'bound>` st= ruct tied to the DRM registration lifetime. It builds on top of Danilo Krum= mrich's drm-lifetime series, which introduces `Registration::new_with_lt()`= and the `RegistrationData` associated type on `drm::Driver`. The patch correctly establishes lifetime and ownership patterns for resourc= es that firmware loading and GPU VM setup will need. The `Firmware` and `Mm= u` stubs are minimal and appropriate for scaffolding future work. **Strengths:** - Clean separation between DRM device data (now empty) and registration-sco= ped resources - Correct use of the `ForLt` higher-kinded type pattern for lifetime-parame= terized registration data - Reasonable safety argument for `new_with_lt` - Stub modules are clearly documented as placeholders **Concerns (minor to moderate):** - The `Mmu` object is created, logs information, and is immediately dropped= =E2=80=94 it's not stored anywhere - `pr_info!` in `mmu.rs` should use `dev_info!` with a device reference - Missing `PinnedDrop` for `TyrDrmRegistrationData` to handle clock cleanup= (depends on whether the base series changed `Clk` to auto-disable on drop) --- --- Generated by Claude Code Patch Reviewer