From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/v3d: Scheduler and submission fixes and refactoring Date: Thu, 04 Jun 2026 11:24:38 +1000 Message-ID: In-Reply-To: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> References: <20260603-v3d-sched-misc-fixes-v3-0-d7114bba55a0@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/v3d: Scheduler and submission fixes and refactoring Author: =?utf-8?q?Ma=C3=ADra_Canal?= Patches: 15 Reviewed: 2026-06-04T11:24:38.873719 --- This is a well-structured 14-patch series from Maira Canal that addresses scheduler and submission issues in the V3D driver. The series progresses logically from small cleanups/fixes (patches 1-6) through a DRM exec migration (patch 7), into a major refactoring of the submission code around a new `struct v3d_submit` abstraction (patches 8-12), adding out_sync validation (patch 13), and finally ensuring atomic submissions (patch 14). The overall approach is sound. The `struct v3d_submit` abstraction is a clear improvement that unifies the previously ad-hoc per-ioctl submission patterns. The incremental decomposition makes the refactoring reviewable despite its scope. There is one correctness issue (missing bounds check in `v3d_submit_add_job`), a few minor items, and the series is otherwise in good shape. Several patches already carry Reviewed-by tags from Tvrtko Ursulin and Iago Toral. --- Generated by Claude Code Patch Reviewer