From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: ForLt/CovariantForLt split, auxiliary closure API and DevresLt Date: Thu, 04 Jun 2026 12:08:38 +1000 Message-ID: In-Reply-To: <20260603011020.2073650-1-dakr@kernel.org> References: <20260603011020.2073650-1-dakr@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: ForLt/CovariantForLt split, auxiliary closure API and DevresLt Author: Danilo Krummrich Patches: 11 Reviewed: 2026-06-04T12:08:38.911660 --- This is a well-designed series that splits the existing `ForLt` trait into = a two-level hierarchy to support both covariant and invariant lifetime-para= meterized types in the kernel's device resource management infrastructure. = The motivation is clear: types like `Mutex<&'bound T>` are invariant over t= heir lifetime parameter and cannot safely use `cast_ref()`, but they still = need to participate in the `Devres`/registration-data patterns. The series is cleanly structured: rename first, introduce the base trait, a= dd the closure-based API, demonstrate it in a sample, then build `DevresLt`= on top, and finally convert the concrete types. The safety arguments are s= ound =E2=80=94 the HRTB closure pattern (`for<'a> FnOnce(...)`) is a well-e= stablished technique for preventing lifetime smuggling with invariant types. No correctness bugs found. A few minor observations follow. --- Generated by Claude Code Patch Reviewer