Claude review: dma-fence: Use dma_fence_set_error() internally

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: dma-fence: Use dma_fence_set_error() internally
Author: Philipp Stanner <phasta@kernel.org>
Patches: 1
Reviewed: 2026-06-04T11:41:50.918398

---

This is a single-patch series making a trivial cleanup in `dma_fence_release()`: replacing a direct assignment `fence->error = -EDEADLK` with the API helper `dma_fence_set_error(fence, -EDEADLK)`. The intent is to improve readability and consistency by using the designated API.

The change is **correct but has a minor behavioral subtlety worth noting**. The `dma_fence_set_error()` helper (defined at `include/linux/dma-fence.h:686`) includes two `WARN_ON` checks:

```c
WARN_ON(test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags));
WARN_ON(error >= 0 || error < -MAX_ERRNO);
```

The second check is trivially satisfied since `-EDEADLK` is always a valid negative errno. The first check — that the fence is not already signaled — is also safe in this context because the enclosing `if` at line 581 explicitly verified `!dma_fence_test_signaled_flag(fence)` before entering the block.

There is a theoretical race window: the `!dma_fence_test_signaled_flag()` check at line 581 is done without the fence lock, and the lock is only acquired at line 601. In principle, another thread could signal the fence between the check and the lock acquisition, causing the `WARN_ON` inside `dma_fence_set_error()` to fire. **However, this same race existed before this patch** — the original code would have set the error on an already-signaled fence too, and then called `dma_fence_signal_locked()` which also has its own signaled-state handling. Furthermore, we are in `dma_fence_release()` meaning the refcount has hit zero, so concurrent signaling would be a separate bug. This patch does not make that situation any worse; the new `WARN_ON` would actually *help* detect it.

Overall: a clean, low-risk readability improvement. No functional concerns.

---
Generated by Claude Code Patch Reviewer