From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xe/pagefault: Add SRCID to pagefault reporting Date: Thu, 04 Jun 2026 11:40:32 +1000 Message-ID: In-Reply-To: <20260603150828.3751112-1-jonathan.cavitt@intel.com> References: <20260603150828.3751112-1-jonathan.cavitt@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/xe/pagefault: Add SRCID to pagefault reporting Author: Jonathan Cavitt Patches: 3 Reviewed: 2026-06-04T11:40:32.542120 --- This is a clean, small 2-patch series that adds the SRCID (source ID of the faulting hardware unit) to the xe pagefault reporting path. The data flows correctly from the GuC G2H message through the internal pagefault struct, into the per-VM fault entry, and out to userspace via the `xe_vm_get_property_ioctl`. The UAPI change reuses the existing `pad` byte in `struct xe_vm_fault`, which is correct since userspace was already required to pass it as zero (MBZ). The series is straightforward and the implementation is consistent with the existing patterns for the other fault fields (access_type, fault_type, fault_level). One minor concern and one nit below. **Verdict: Looks good with minor comments.** --- --- Generated by Claude Code Patch Reviewer