From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: RPM, perfcnt and other minor fixes for Panfrost Date: Fri, 05 Jun 2026 06:16:23 +1000 Message-ID: In-Reply-To: <20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com> References: <20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: RPM, perfcnt and other minor fixes for Panfrost Author: =?utf-8?q?Adri=C3=A1n_Larumbe?= Patches: 19 Reviewed: 2026-06-05T06:16:23.718180 --- This is a 7-patch series for the Panfrost GPU driver addressing RPM (Runtime Power Management) reference counting, perfcnt reset handling, and several minor robustness fixes. The series is well-structured with preparatory refactoring patches (3, 4) separated from the actual fixes (5, 6, 7). The two most important patches are patch 6 (PM usage_count fix) and patch 5 (perfcnt reset handling), which address real bugs. There is one clear **bug** in patch 5 (missing negative return value), and a few design concerns around the perfcnt reset atomics that warrant discussion. The minor patches (1, 2, 3, 4) are straightforward and look correct. Overall the series is in reasonable shape but patch 5 needs a fix before it can be merged. --- --- Generated by Claude Code Patch Reviewer