From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add SCDC information to connector debugfs Date: Fri, 05 Jun 2026 06:21:28 +1000 Message-ID: In-Reply-To: <20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com> References: <20260604-scdc-link-health-v5-0-11173b0ac3de@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add SCDC information to connector debugfs Author: Nicolas Frattaroli Patches: 5 Reviewed: 2026-06-05T06:21:28.383397 --- This v5 series adds SCDC (Status and Control Data Channel) debugfs support for HDMI connectors, exposing link health information that's useful for debugging cable/signal issues. The series is well-structured: a clean return-type fix, the core debugfs infrastructure, a bridge connector hookup, and HDMI 2.1 extensions. The code is generally well-written and has clearly benefited from multiple review rounds. However, there are a few issues worth addressing: a **one-off error in the SCDC 256-byte read** that misses the last register, a **misplaced `drm_connector_put()` on the success path** that drops the reference before the function is done, a **missing `else` zeroing for `rs_corrections`**, and **parsed training pattern fields that are never displayed**. None are catastrophic, but the first two should be fixed before merge. --- Generated by Claude Code Patch Reviewer