From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Date: Fri, 05 Jun 2026 06:28:17 +1000 Message-ID: In-Reply-To: <20260604-shikra-display-v2-0-b3c1b2b67edc@oss.qualcomm.com> References: <20260604-shikra-display-v2-0-b3c1b2b67edc@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Subject: [PATCH 0/3] Add Shikra (QCM2390) display support Author: Nabige Aala Patches: 13 Reviewed: 2026-06-05T06:28:17.480005 --- This is a straightforward 3-patch series adding display support for the Qua= lcomm Shikra (QCM2390) SoC, which reuses the same DPU 6.5 hardware as QCM22= 90. The approach of using DT compatible fallback strings to avoid separate = driver patches is correct and clean =E2=80=94 `dpu_kms.c` already has `qcom= ,qcm2290-dpu` in its OF match table, so nodes with `compatible =3D "qcom,sh= ikra-dpu", "qcom,qcm2290-dpu"` will match without driver changes. The v2 re= visions (dropping the drm/msm and SMMU patches, fixing the UBWC data mappin= g) are well-motivated and address v1 review feedback properly. There are a few minor issues: a stale diffstat in the cover letter, a forma= tting nit in the DPU binding, and a cover letter subject line duplication. = Nothing that blocks merging, but worth cleaning up. The series depends on the ILI7807S panel driver prerequisite (`Prerequisite= -Message-Id` references an earlier series) =E2=80=94 patch 2 (defconfig ena= blement) is only useful once that driver lands. --- --- Generated by Claude Code Patch Reviewer