From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: couple of visionox vtdr6140 driver enhancements Date: Fri, 05 Jun 2026 06:24:32 +1000 Message-ID: In-Reply-To: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> References: <20260604-topic-sm8x50-vtdr6130-dsc-v1-0-09bcd1dff1fb@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel: couple of visionox vtdr6140 driver enhancements Author: Neil Armstrong Patches: 5 Reviewed: 2026-06-05T06:24:32.822781 --- This is a clean 2-patch series from Neil Armstrong (with Jun Nie as author of patch 1) that makes two improvements to the Visionox VTDR6130 panel driver: 1. Enables DSC (Display Stream Compression) v1.2 by populating the `drm_dsc_config` struct and sending the PPS to the panel. 2. Switches to devm-managed panel/DSI-attach calls and drops the manual `remove()` callback. Both patches are straightforward, follow established patterns from other panel drivers (e.g., `panel-visionox-r66451`, `panel-lg-sw43408`), and are correct. The DSC parameters match the PPS blob already hardcoded in the 0x70 vendor register (version 1.2, 2400x1080, slice 40x540), confirming consistency. The devm conversion is a standard modernization. **Series looks good to merge.** One minor observation below but nothing blocking. --- Generated by Claude Code Patch Reviewer