From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo() Date: Fri, 05 Jun 2026 06:45:30 +1000 Message-ID: In-Reply-To: <20260604025315.245910-1-jhubbard@nvidia.com> References: <20260604025315.245910-1-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: libfs: set SB_I_NOEXEC and SB_I_NODEV in init_pseudo() Author: John Hubbard Patches: 3 Reviewed: 2026-06-05T06:45:30.562685 --- This is a clean, well-motivated 2-patch series that fixes a real `path_noex= ec()` warning triggered by `CONFIG_DEBUG_VFS=3Dy` on dma-buf mmap. The appr= oach =E2=80=94 setting `SB_I_NOEXEC | SB_I_NODEV` in `init_pseudo()` rather= than per-caller =E2=80=94 is the right level of abstraction, as suggested = by Christoph Hellwig. Pseudo-filesystems are `SB_NOUSER` mounts that are ne= ver path-reachable, so both flags are safe defaults. The series is properly structured: patch 1 is the functional fix (with `Fix= es:` and `Cc: stable`), and patch 2 is a pure cleanup. The cover letter inc= ludes a thorough audit table of all `init_pseudo()` callers, which inspires= confidence. **No correctness issues found.** The series looks ready to merge. --- --- Generated by Claude Code Patch Reviewer