From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Fix mem_type change detection for async flips Date: Fri, 05 Jun 2026 06:42:09 +1000 Message-ID: In-Reply-To: <20260604064424.3154796-1-matthew.schwartz@linux.dev> References: <20260604064424.3154796-1-matthew.schwartz@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Fix mem_type change detection for async flips Author: Matthew Schwartz Patches: 2 Reviewed: 2026-06-05T06:42:09.444539 --- This is a single-patch fix for a clear and real bug in `amdgpu_dm_crtc_mem_type_changed()`. The analysis in the commit message is accurate: `drm_atomic_get_plane_state()` is a get-or-allocate function that returns the **new** state pointer (or allocates one if the plane isn't yet in the commit). Calling it twice for the same plane returns the same pointer both times, so the comparison `get_mem_type(old_plane_state->fb) != get_mem_type(new_plane_state->fb)` always evaluates to false, completely defeating the mem_type change detection. The fix is correct, minimal, and well-explained. **Recommend merge.** --- Generated by Claude Code Patch Reviewer