From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/virtgpu: Use ERR_PTR for fb_create callback error return Date: Fri, 05 Jun 2026 06:40:48 +1000 Message-ID: In-Reply-To: <20260604071202.138235-1-liuqiangneo@163.com> References: <20260604071202.138235-1-liuqiangneo@163.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/virtgpu: Use ERR_PTR for fb_create callback error return Author: liuqiangneo@163.com Patches: 1 Reviewed: 2026-06-05T06:40:48.679987 --- This is a single-patch series that fixes a real bug in the `virtio_gpu_user= _framebuffer_create` function. The `fb_create` callback contract (documente= d in `drm_mode_config.h:78-81`) explicitly states it must return "a negativ= e error code encoded with ERR_PTR()" on failure. However, one error path wa= s returning `NULL` instead, which violates this contract and would cause th= e DRM core caller to misinterpret the error. The fix is correct, minimal, and consistent with the other error paths in t= he same function, which all already use `ERR_PTR()`. This is a clear bug fi= x =E2=80=94 **recommend accepting**. --- Generated by Claude Code Patch Reviewer