From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: samsung-dsim: fix TE GPIO ownership
Date: Fri, 05 Jun 2026 06:32:39 +1000 [thread overview]
Message-ID: <review-overall-20260604114604.1422184-1-lgs201920130244@gmail.com> (raw)
In-Reply-To: <20260604114604.1422184-1-lgs201920130244@gmail.com>
Overall Series Review
Subject: drm/bridge: samsung-dsim: fix TE GPIO ownership
Author: Guangshuo Li <lgs201920130244@gmail.com>
Patches: 1
Reviewed: 2026-06-05T06:32:39.803290
---
This is a single-patch fix for a real resource management bug in the Samsung DSIM bridge driver. The analysis in the commit message is correct: `devm_gpiod_get_optional()` registers a devres cleanup action that will call `gpiod_put()` automatically on device detach, but the driver also manually calls `gpiod_put()` in both the error path of `samsung_dsim_register_te_irq()` and in `samsung_dsim_unregister_te_irq()`. This results in a double-free of the GPIO descriptor — once via the manual `gpiod_put()` and again when devres runs during device detach.
The fix is correct and minimal: switch to non-managed `gpiod_get_optional()` so that the manual `gpiod_put()` calls are the sole owners of the descriptor's lifetime. The addition of `dsi->te_gpio = NULL` after each `gpiod_put()` is a good defensive practice.
**Verdict: Looks good. Correct fix for a genuine double-free bug.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 11:46 [PATCH] drm/bridge: samsung-dsim: fix TE GPIO ownership Guangshuo Li
2026-06-04 20:32 ` Claude Code Review Bot [this message]
2026-06-04 20:32 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604114604.1422184-1-lgs201920130244@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox