From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/virtio: Fix driver removal with disabled KMS
Date: Fri, 05 Jun 2026 06:30:56 +1000 [thread overview]
Message-ID: <review-overall-20260604122743.13383-1-dmitry.osipenko@collabora.com> (raw)
In-Reply-To: <20260604122743.13383-1-dmitry.osipenko@collabora.com>
Overall Series Review
Subject: drm/virtio: Fix driver removal with disabled KMS
Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Patches: 1
Reviewed: 2026-06-05T06:30:56.726523
---
This is a single-patch fix for a kernel crash that occurs when the virtio-gpu driver is removed (unbound) while KMS support is disabled (`CONFIG_DRM_VIRTIO_GPU_KMS=n` or the device reports zero scanouts). The fix is correct in concept: when KMS is disabled, `dev->driver_features` has `DRIVER_MODESET | DRIVER_ATOMIC` cleared and `drmm_mode_config_init()` is never called, so calling `drm_atomic_helper_shutdown()` unconditionally accesses uninitialized mode_config state (uninitialized mutexes, zeroed list heads) and crashes.
The patch does **not apply cleanly** to current drm-next. The diff context shows `virtio_gpu_release_vqs(dev)` preceding `drm_dev_unplug(dev)` in `virtio_gpu_remove()`, but the current drm-next tree has no such call — the function is just `drm_dev_unplug` / `drm_atomic_helper_shutdown` / `virtio_gpu_deinit` / `drm_dev_put`. The author appears to have based this on a different tree version. A rebase is needed.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-06-04 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-04 12:27 [PATCH v1] drm/virtio: Fix driver removal with disabled KMS Dmitry Osipenko
2026-06-04 20:30 ` Claude review: " Claude Code Review Bot
2026-06-04 20:30 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260604122743.13383-1-dmitry.osipenko@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox