From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: don't allow changes to inactive colorops Date: Fri, 05 Jun 2026 06:13:38 +1000 Message-ID: In-Reply-To: <20260604180457.1110110-1-mwen@igalia.com> References: <20260604180457.1110110-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: don't allow changes to inactive colorops Author: Melissa Wen Patches: 5 Reviewed: 2026-06-05T06:13:38.976779 --- This is a well-structured 3-patch series from Melissa Wen that establishes a UAPI contract for DRM color pipeline management: userspace may only modify colorop properties when the color pipeline is active (or transitioning active/inactive in the same commit), and colorop settings must persist across deactivation/reactivation cycles. The series is clearly motivated by real userspace expectations discussed with compositors on the Wayland IRC channel and on dri-devel. The approach is sound: 1. Patch 1 narrows which colorops get added to atomic state (only those in the old/new pipeline) when checking affected planes. 2. Patch 2 ensures state duplication (suspend/resume) captures all colorops for persistence. 3. Patch 3 adds the enforcement check in `drm_atomic_check_only()` that rejects colorop modifications on inactive pipelines. The series is generally clean and well-commented, with good V2 refinements (the `drm_for_each_colorop_in_pipeline` macro). There are a few issues worth discussing, detailed below. --- --- Generated by Claude Code Patch Reviewer