From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v2 0/4] accel: rocket: Add RK3568 NPU support Date: Thu, 04 Jun 2026 16:18:11 +1000 Message-ID: In-Reply-To: <26069b3b-43c0-45fa-92ee-729d270a8b6b@kernel.org> References: <26069b3b-43c0-45fa-92ee-729d270a8b6b@kernel.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH v2 0/4] accel: rocket: Add RK3568 NPU support Author: Krzysztof Kozlowski Patches: 9 Reviewed: 2026-06-04T16:18:11.541424 --- This 4-patch series adds Rockchip RK3568 NPU support to the upstream `rocket` accel driver. The approach is reasonable: a `rocket_soc_data` abstraction cleanly separates SoC-specific parameters (DMA width, NOC init) from common logic. The DT binding, DTS, and board enablement patches are largely straightforward. However, there are several issues ranging from a binding YAML syntax error to a runtime PM gap, plus some kernel coding style concerns. The author is upfront that end-to-end inference is not yet working, which is fair for a v2 driver/DT infrastructure submission, but reviewers should weigh whether merging hardware bring-up code without a working end-to-end path is appropriate. The cover letter is exceptionally detailed and transparent about the current state, which is commendable. --- --- Generated by Claude Code Patch Reviewer