From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/mgag200: reject pixel clocks outside PLL range Date: Mon, 18 May 2026 16:11:33 +1000 Message-ID: In-Reply-To: <28e476e896dafdd31518dc5360ab7766@berkoc.com> References: <28e476e896dafdd31518dc5360ab7766@berkoc.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/mgag200: reject pixel clocks outside PLL range Author: Berkant Koc Patches: 1 Reviewed: 2026-05-18T16:11:33.330911 --- This is a single patch that adds a `permitteddelta` sanity check to six mgag200 PLL compute helpers (g200wb, g200eh, g200er, g200ev, g200eh3, g200ew3), matching what g200se already has. The problem is real: without the check, when no PLL register combination matches the requested pixel clock, `m`, `n`, `p`, `s` remain at zero, and `atomic_update` programs garbage into the PIXPLLC registers. The fix is correct and mechanically consistent with the g200se reference. The `Fixes:` tag and `Cc: stable` are appropriate. One style concern worth raising, and one minor functional observation. --- Generated by Claude Code Patch Reviewer