From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: apple_bl: Convert to a platform driver
Date: Mon, 16 Mar 2026 11:59:43 +1000 [thread overview]
Message-ID: <review-overall-5084777.GXAFRqVoOG@rafael.j.wysocki> (raw)
In-Reply-To: <5084777.GXAFRqVoOG@rafael.j.wysocki>
Overall Series Review
Subject: backlight: apple_bl: Convert to a platform driver
Author: "Rafael J. Wysocki" <rafael@kernel.org>
Patches: 1
Reviewed: 2026-03-16T11:59:43.952358
---
This is a single patch that converts the Apple backlight ACPI driver (`apple_bl`) from using `struct acpi_driver` to `struct platform_driver`. This is part of a broader effort by Rafael to move drivers away from binding directly to ACPI device objects and instead binding to the platform devices that the ACPI core already creates.
The conversion is clean and correct. The patch is small, well-scoped, and the commit message clearly explains the rationale and references the broader discussion about why drivers should not bind directly to ACPI device objects.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-16 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 11:50 [PATCH v1] backlight: apple_bl: Convert to a platform driver Rafael J. Wysocki
2026-03-16 1:59 ` Claude Code Review Bot [this message]
2026-03-16 1:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-5084777.GXAFRqVoOG@rafael.j.wysocki \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox