From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Date: Wed, 11 Feb 2026 17:11:30 +1000 Message-ID: In-Reply-To: <5535ac41-efb8-4bf5-91bb-9b6f63517e8f@collabora.com> References: <5535ac41-efb8-4bf5-91bb-9b6f63517e8f@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: Re: [PATCH] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Author: AngeloGioacchino Del Regno Patches: 4 Reviewed: 2026-02-11T17:11:30.197586 --- This is a single-patch submission that fixes a critical NULL pointer dereference in the MediaTek DSI driver. The patch addresses an initialization ordering issue where `mipi_dsi_host_register()` is called before `platform_set_drvdata()`, causing a crash when the registration triggers callbacks that attempt to retrieve the driver data. **Summary:** - **Type:** Bug fix - **Severity:** Critical (kernel crash/NULL pointer dereference) - **Complexity:** Simple (2-line move) - **Testing:** Verified on Xiaomi Smart Clock x04g (MT8167) **Overall Assessment:** This is a correct fix for a real bug. The patch has already received a Reviewed-by tag from AngeloGioacchino Del Regno, a maintainer familiar with this subsystem. However, there are some issues with the patch metadata that should be addressed. --- Generated by Claude Code Patch Reviewer