From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/amdgpu: deduplicate ring preempt ib function Date: Thu, 23 Apr 2026 07:52:56 +1000 Message-ID: In-Reply-To: <59b686c6-42f5-4cde-8199-dae64722bfd1@amd.com> References: <59b686c6-42f5-4cde-8199-dae64722bfd1@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] drm/amdgpu: deduplicate ring preempt ib function Author: =?UTF-8?Q?Christian_K=C3=B6nig?= Patches: 3 Reviewed: 2026-04-23T07:52:56.153629 --- This is a straightforward and correct deduplication patch. The `ring_preempt_ib` function bodies in `gfx_v11_0.c` and `gfx_v12_0.c` are byte-for-byte identical, so extracting them into a shared `amdgpu_gfx_ring_preempt_ib()` in `amdgpu_gfx.c` is the right thing to do. The patch is clean, the logic is preserved faithfully, and the call sites are updated correctly. There are a few minor style issues and one missed deduplication opportunity worth raising. **Verdict: Looks good with minor nits.** --- Generated by Claude Code Patch Reviewer