From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau: fix misleading indentation Date: Sat, 14 Mar 2026 07:24:31 +1000 Message-ID: In-Reply-To: <6c1d96782664e4f491f23e8c73545fe4d8b9533a.1773383224.git.joeypabalinas@gmail.com> References: <6c1d96782664e4f491f23e8c73545fe4d8b9533a.1773383224.git.joeypabalinas@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/nouveau: fix misleading indentation Author: Joey Pabalinas Patches: 1 Reviewed: 2026-03-14T07:24:31.945133 --- **NAK =E2=80=94 This patch introduces functional regressions by changing co= de semantics.** The patch claims to "fix misleading indentation" but the original indentati= on was **intentional and correct**. The existing code uses a well-known (if= unusual) kernel coding pattern: `else\nif (...)` as a continuation of an i= f/else-if chain at the same logical nesting level. The patch misinterprets = this as "misleading indentation" and re-indents the `else` branches to be n= ested inside the preceding `else`, which **changes the logical structure of= the code** in at least one case. --- Generated by Claude Code Patch Reviewer