From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] drm/i915/color: Fix plane color pipeline programming bugs Date: Mon, 25 May 2026 19:42:43 +1000 Message-ID: In-Reply-To: <6d8e36e2aea806f9973b3c501aad4523f7316d6a@intel.com> References: <6d8e36e2aea806f9973b3c501aad4523f7316d6a@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] drm/i915/color: Fix plane color pipeline programming b= ugs Author: Jani Nikula Patches: 5 Reviewed: 2026-05-25T19:42:43.331225 --- This mbox contains **three patches**: the v1 combined patch (`[PATCH]`) and= the v2 series split into two (`[PATCH v2 1/2]` and `[PATCH v2 2/2]`). The = v1 is superseded by v2. The review focuses on the v2 series. The fixes are correct in substance =E2=80=94 both address a real step-disco= ntinuity bug in the i915 plane color LUT programming where Segment 2 was ha= rdcoded to `1 << 24` instead of continuing from the last user-provided LUT = entry. However, **Patch v2 2/2 has a stale commit message that must be fixe= d before merging**. The code changes are small, well-scoped, and the split into separate pre-CS= C and post-CSC patches is a good improvement over v1. --- --- Generated by Claude Code Patch Reviewer