From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: compute audio CTS from N when not in TMDS table Date: Mon, 25 May 2026 22:06:43 +1000 Message-ID: In-Reply-To: <81944af1-c9e3-4a45-ad42-3426dcab0777@kwiboo.se> References: <81944af1-c9e3-4a45-ad42-3426dcab0777@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH v2] drm/bridge: dw-hdmi-qp: compute audio CTS from N wh= en not in TMDS table Author: Jonas Karlman Patches: 3 Reviewed: 2026-05-25T22:06:43.782096 --- This is a single, well-motivated patch that fixes an audio mute issue on HD= MI sinks when using TMDS character rates not covered by the static CTS look= up table (`common_tmds_cts_table[]`). The commit message is excellent =E2= =80=94 clear problem statement, root cause analysis, the fix rationale, pre= cedent in the legacy driver, and comprehensive test results across multiple= sinks and rates. The code change is small, correct, and follows an established pattern from = the legacy `dw-hdmi.c` driver. The formula `CTS =3D (TMDS * N) / (128 * Fs)= ` is straight from the HDMI specification. **Verdict: This patch looks good and is ready to apply.** One minor observa= tion below, but nothing blocking. --- Generated by Claude Code Patch Reviewer