From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: dw-hdmi-qp: use drm_hdmi_acr_get_n_cts() helper for audio N/CTS
Date: Mon, 25 May 2026 20:47:24 +1000 [thread overview]
Message-ID: <review-overall-86fcf349-0a7a-4618-9001-612371b0f71b@symple.nz> (raw)
In-Reply-To: <86fcf349-0a7a-4618-9001-612371b0f71b@symple.nz>
Overall Series Review
Subject: drm/bridge: dw-hdmi-qp: use drm_hdmi_acr_get_n_cts() helper for audio N/CTS
Author: Simon Wright <simon@symple.nz>
Patches: 1
Reviewed: 2026-05-25T20:47:24.201809
---
This is a clean, well-motivated single patch that replaces ~200 lines of open-coded HDMI Audio Clock Regeneration (ACR) N/CTS lookup tables and computation functions with a single call to the existing shared helper `drm_hdmi_acr_get_n_cts()`. The patch fixes a real audio bug on strict HDMI sinks (LG G3 OLED) at TMDS rates not present in the removed CTS table, and the commit message is thorough with excellent testing documentation.
**Verdict: Looks good.** No correctness issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 7:36 [PATCH v3] drm/bridge: dw-hdmi-qp: use drm_hdmi_acr_get_n_cts() helper for audio N/CTS Simon Wright
2026-05-25 10:47 ` Claude Code Review Bot [this message]
2026-05-25 10:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-86fcf349-0a7a-4618-9001-612371b0f71b@symple.nz \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox