From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter Date: Mon, 13 Apr 2026 18:50:47 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH v3] staging: fbtft: replace empty macro args with ident= ity converter Author: Andy Shevchenko Patches: 5 Reviewed: 2026-04-13T18:50:47.485308 --- This mbox contains two patches addressing the same issue in `drivers/stagin= g/fbtft/fbtft-bus.c`: the `define_fbtft_write_reg` macro is invoked with an= empty 4th argument for the no-conversion cases. Patch 1 is a broken v1 tha= t removes the argument entirely, while Patch 2 (labeled v3) is the correcte= d approach that introduces an identity macro. Only Patch 2 should be consid= ered for merging. The series has formatting/process issues: Patch 1 is a standalone `[PATCH]`= (not a cover letter) that contains a full diff of a broken approach, and P= atch 2 is `[PATCH v3]` sent as a reply. This is confusing =E2=80=94 v3 shou= ld have been sent as its own top-level thread, with a note that it supersed= es the prior versions. Patch 2 is functionally correct but its commit message makes an inaccurate = claim about undefined behavior. --- Generated by Claude Code Patch Reviewer