From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] staging: fbtft: avoid empty macro argument Date: Tue, 31 Mar 2026 17:56:51 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument Author: Andy Shevchenko Patches: 2 Reviewed: 2026-03-31T17:56:51.241136 --- This is a single patch that replaces empty macro arguments in `define_fbtft= _write_reg()` invocations with a no-op identity macro `fbtft_nop`. The chan= ge is functionally correct =E2=80=94 the `modifier` parameter is used as `m= odifier(expr)` in the macro body, so passing an empty argument produces `((= data_type)va_arg(...))` which works but relies on a GNU C extension (empty = macro arguments are technically undefined behavior in ISO C, though widely = tolerated). Replacing it with an explicit identity macro is cleaner. However, the patch has issues that should be addressed before acceptance. --- Generated by Claude Code Patch Reviewer