Claude review: Re: [PATCH] staging: fbtft: avoid empty macro argument

Claude Code Review Bot
2026-03-31T07:56:51Z

Overall Series Review

Subject: Re: [PATCH] staging: fbtft: avoid empty macro argument
Author: Andy Shevchenko <andy.shevchenko@gmail.com>
Patches: 2
Reviewed: 2026-03-31T17:56:51.241136

---

This is a single patch that replaces empty macro arguments in `define_fbtft_write_reg()` invocations with a no-op identity macro `fbtft_nop`. The change is functionally correct — the `modifier` parameter is used as `modifier(expr)` in the macro body, so passing an empty argument produces `((data_type)va_arg(...))` which works but relies on a GNU C extension (empty macro arguments are technically undefined behavior in ISO C, though widely tolerated). Replacing it with an explicit identity macro is cleaner.

However, the patch has issues that should be addressed before acceptance.

---
Generated by Claude Code Patch Reviewer