From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amd/display: Deduplicate DCN DDC register assignment Date: Wed, 01 Apr 2026 08:00:39 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amd/display: Deduplicate DCN DDC register assignment Author: Guilherme Ivo Bozi Patches: 2 Reviewed: 2026-04-01T08:00:39.540443 --- This is a clean, straightforward deduplication patch (v3) that extracts identical `define_ddc_registers()` bodies from 6 DCN generation files into a shared `static inline` helper in a new header. The approach is sound: the function bodies were truly identical across all 6 files, the types are correct (`struct ddc_sh_mask` matches the actual declarations), and the inline helper avoids any function pointer indirection overhead. **Verdict: Looks good overall, with minor issues noted below.** --- Generated by Claude Code Patch Reviewer