From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and device tree Date: Thu, 23 Apr 2026 10:19:49 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and devic= e tree Author: Dmitry Baryshkov Patches: 17 Reviewed: 2026-04-23T10:19:49.194403 --- This series adds a DRM bridge driver for the Lontium LT9611C/EX/UXD MIPI DS= I-to-HDMI converter chips, along with a dt-bindings update. The driver uses= an interesting architecture where commands are sent to an on-chip MCU via = a read/write flow protocol rather than directly programming hardware regist= ers. The v3 changelog shows good progress incorporating review feedback (us= ing `devm_drm_bridge_alloc`, HDMI audio helpers, CRC8 library, etc.). However, there are several significant issues that need to be addressed bef= ore this can be merged: 1. **Missing `DRM_BRIDGE_OP_HDMI` flag** =E2=80=94 The driver implements AV= I, HDMI, and SPD infoframe callbacks but does not set `DRM_BRIDGE_OP_HDMI` = (or `DRM_BRIDGE_OP_HDMI_SPD_INFOFRAME`) in `bridge.ops`. Without these flag= s, the framework will never call those callbacks. The existing lt9611 drive= r sets these correctly. This also means `vendor`, `product`, `supported_for= mats`, and `max_bpc` must be set on the bridge. 2. **Buffer overflow in infoframe write functions** =E2=80=94 The infoframe= callbacks copy `len` bytes from `buffer` into a fixed 16-byte command arra= y without bounds checking. An infoframe can be up to ~31 bytes, overflowing= the stack buffer. 3. **Improper error returns** =E2=80=94 Several functions return magic valu= es like `-1` or `-2` instead of proper errno codes. 4. **dt-bindings patch uses fullwidth punctuation** and has formatting issu= es. 5. **`SET_SYSTEM_SLEEP_PM_OPS` is deprecated** =E2=80=94 should use `DEFINE= _SIMPLE_DEV_PM_OPS`. 6. **Missing `atomic_duplicate_state`/`atomic_reset`** bridge callbacks. 7. **Sysfs firmware upgrade interface** is unusual and needs better justifi= cation. --- --- Generated by Claude Code Patch Reviewer