From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: validate doorbell_offset in user queue creation Date: Wed, 25 Mar 2026 06:55:42 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: validate doorbell_offset in user queue creation Author: Junrui Luo Patches: 2 Reviewed: 2026-03-25T06:55:42.528640 --- This is a single-patch fix that adds bounds checking for the user-provided `doorbell_offset` before it is passed to `amdgpu_doorbell_index_on_bar()` during usermode queue creation. The fix addresses a real security issue: a malicious or buggy userspace could provide an out-of-bounds doorbell offset, causing accesses outside the doorbell BO. The fix is correct in approach and small in scope. **Verdict: The patch is reasonable and addresses a legitimate vulnerability, but has a minor issue worth noting.** --- Generated by Claude Code Patch Reviewer