From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: take fl->lock when moving mmaps on interrupted invoke Date: Thu, 04 Jun 2026 13:14:39 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: take fl->lock when moving mmaps on interrupted invoke Author: Junrui Luo Patches: 1 Reviewed: 2026-06-04T13:14:39.432840 --- This is a single-patch fix for a missing lock in the FastRPC driver's signal-interrupted invoke path. The commit message correctly identifies the bug: `fl->mmaps` is manipulated without `fl->lock` when moving entries to `cctx->invoke_interrupted_mmaps` after `-ERESTARTSYS`. The fix is correct for the `fl->mmaps` side, but there is a remaining concern about the destination list. **Verdict: The patch is a net improvement and fixes a real race, but has an incomplete locking story for the destination list.** --- --- Generated by Claude Code Patch Reviewer