From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: fix DMA address corruption due to find_vma misuse Date: Sat, 16 May 2026 09:24:08 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: fix DMA address corruption due to find_vma misuse Author: Junrui Luo Patches: 1 Reviewed: 2026-05-16T09:24:08.007858 --- This is a single-patch fix for a real bug in the fastrpc driver. The analys= is is correct: `find_vma()` returns the first VMA with `vma->vm_end > addr`= , which means if the address falls in a gap *before* that VMA, the subseque= nt arithmetic `(ptr & PAGE_MASK) - vma->vm_start` will underflow (since `pt= r` could be well below `vma->vm_start`), corrupting the DMA address passed = to the DSP. Replacing with `vma_lookup()` is the standard and correct fix = =E2=80=94 it returns NULL when the address is not contained within any VMA,= so the offset calculation is only performed when the address genuinely bel= ongs to the found VMA. The patch is minimal, correct, and appropriate for stable backport. **Verdict: Looks good.** --- Generated by Claude Code Patch Reviewer