From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amdgpu/userq: fix memory leak in MQD creation error paths
Date: Mon, 16 Mar 2026 11:58:18 +1000 [thread overview]
Message-ID: <review-overall-SYBPR01MB7881A279A361F81B670CDEEAAF42A@SYBPR01MB7881.ausprd01.prod.outlook.com> (raw)
In-Reply-To: <SYBPR01MB7881A279A361F81B670CDEEAAF42A@SYBPR01MB7881.ausprd01.prod.outlook.com>
Overall Series Review
Subject: drm/amdgpu/userq: fix memory leak in MQD creation error paths
Author: Junrui Luo <moonafterrain@outlook.com>
Patches: 3
Reviewed: 2026-03-16T11:58:18.192377
---
This is a single-patch fix for a real memory leak in `mes_userqueue.c`. The bug analysis is correct: when `amdgpu_userq_input_va_validate()` fails after a successful `memdup_user()`, the allocated IP-specific MQD struct is not freed before jumping to `free_mqd`. The fix is straightforward and appropriate.
**Verdict: Correct fix, with minor suggestions below.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-16 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 15:33 [PATCH] drm/amdgpu/userq: fix memory leak in MQD creation error paths Junrui Luo
2026-03-14 20:04 ` Markus Elfring
2026-03-15 5:25 ` Junrui Luo
2026-03-15 9:50 ` Markus Elfring
2026-03-16 1:58 ` Claude review: " Claude Code Review Bot
2026-03-16 1:58 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-SYBPR01MB7881A279A361F81B670CDEEAAF42A@SYBPR01MB7881.ausprd01.prod.outlook.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox