From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu/userq: fix memory leak in MQD creation error paths Date: Mon, 16 Mar 2026 11:58:18 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu/userq: fix memory leak in MQD creation error paths Author: Junrui Luo Patches: 3 Reviewed: 2026-03-16T11:58:18.192377 --- This is a single-patch fix for a real memory leak in `mes_userqueue.c`. The bug analysis is correct: when `amdgpu_userq_input_va_validate()` fails after a successful `memdup_user()`, the allocated IP-specific MQD struct is not freed before jumping to `free_mqd`. The fix is straightforward and appropriate. **Verdict: Correct fix, with minor suggestions below.** --- Generated by Claude Code Patch Reviewer