From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: fix error handling bugs in amdgpu_userq_create() Date: Sun, 12 Apr 2026 09:10:36 +1000 Message-ID: In-Reply-To: References: X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: fix error handling bugs in amdgpu_userq_create() Author: Junrui Luo Patches: 1 Reviewed: 2026-04-12T09:10:36.963748 --- This is a 2-patch series from Junrui Luo fixing error handling bugs in `amdgpu_userq_create()` related to the XArray-based queue tracking introduced by commit f18719ef4bb7. The series claims to fix a use-after-free and a resource leak in error paths. **Critical issue: The mbox file only contains the cover letter (patch 0/2).** The actual patches (1/2 and 2/2) were not captured in the filtered mbox, so this review is based on the cover letter descriptions and analysis of the current source tree. **The patches could not be applied**, and analyzing the current drm-next code at `drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c`, **both issues described in the cover letter appear to already be fixed** in the current tree. The error paths in `amdgpu_userq_create()` on drm-next already properly handle cleanup of both the XArray entries and the MQD/fence resources. This strongly suggests these fixes (or equivalent ones) have already been merged. --- --- Generated by Claude Code Patch Reviewer